Skip to content

Commit

Permalink
Correct bounces to nonexistent error pages
Browse files Browse the repository at this point in the history
If someone tries to do an order return for an order that's not their
own, I'm not worried about explaining the details; just bounce them to
their order return list page now instead of the 404 they were getting
before.

This was reported by John Young <john_young@sonic.net> on 2004-04-13 but
apparently fell between the cracks:

http://www.icdevgroup.org/pipermail/interchange-users/2004-April/038696.html
  • Loading branch information
jonjensen committed Sep 28, 2009
1 parent ad9d457 commit 5377377
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions dist/standard/pages/query/order_return.html
Expand Up @@ -29,7 +29,7 @@
[if session arg]
[seti arg][data session arg][/seti]
[else]
[bounce href="[area special/violation arg_missing]"]
[bounce page=member/returns]
[/else]

[/if]
Expand All @@ -42,17 +42,12 @@
]"
hide=1]

[if value test_user]
[else]
[bounce href="[area special/violation user_missing]&user=[value test_user]&arg=[scratch arg]"]
[/else]
[/if]
[if type=explicit compare=`
return 1 if ! $Session->{username};
return 1 if ! $Values->{test_user} or ! $Session->{username};
return 0 if $Session->{username} eq $Values->{test_user};
return 1;
`]
[bounce href="[area special/user_violation username_no_match]&s=[data session username]&v=[value test_user]"]
[bounce page=member/returns]
[/if]

[seti order_status][data table=transactions column=status key='[scratch arg]'][/seti]
Expand Down

0 comments on commit 5377377

Please sign in to comment.