Move version detection to its own routine

interchange · Nov 3, 2017 · a41509c · a41509c
1 parent e32dfbf
commit a41509c
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/Makefile.PL b/Makefile.PL
@@ -709,20 +709,23 @@ EOF
 	# if we are building from a git checkout, then set the VERSION based on the
 	# closest git tag, otherwise use the last hard-coded version
 
-	if (-d "./.git") {
-		$X{VERSION} = qx(git describe --tags --dirty);
-		chomp $X{VERSION};
-		system(qq{echo '"$X{VERSION}"' > _ic_version});
-	}
-	else {
-		$X{VERSION} = $VERSION;
-	}
+	$X{VERSION} = get_dist_version();
+	system(qq{echo '"$X{VERSION}"' > _ic_version});
 
 	mk_initp(\%X);
 	delete $X{RPMBUILDDIR};
     return \%X;
 }
 
+sub get_dist_version {
+	my $vers = $VERSION;
+	if (-d "./.git") {
+		$vers = qx(git describe --tags --dirty);
+		chomp $vers;
+	}
+	$vers;
+}
+
 sub regularize {
 	for (@_) {
 		s/[\\]\n//g;