Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Fixed a bug in the [area] tag when a full URL is passed as the href.
When a fully-qualified URL is passed in the href attribute of the [area] tag and
the form attribute is also used Interchange would overwrite the
protocol://domain portion of the URL with the one in the VendURL configuration
directive.

Please note that if your code relied on this buggy behaviour then you will need
to fix it before upgrading.
  • Loading branch information
pajamian committed Feb 10, 2017
1 parent c34ab59 commit a9db3e3
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 12 additions & 0 deletions UPGRADE
Expand Up @@ -7,6 +7,10 @@ Interchange is designed to be drop-in compatible in its major version.
Briefly summarized, here's what you can expect when upgrading from the
following versions:

5.10.x -- A minor bug was fixed in an edge-case usage of the [area] tag which
could result in incompatibility if your code relies on the buggy
behaviour.

5.6.x -- Perl 5.8.8 or newer is now generally required to run Interchange.
See "Known Issues" below.

Expand Down Expand Up @@ -83,6 +87,14 @@ That's it. Verify your catalog's operation, and you are live.
K N O W N I S S U E S


KNOWN ISSUES UPGRADING FROM 5.10.x

1. A bug was fixed in the [area] tag where if you previously passed a fully
qualified URL as the href and used the form attribute then the protocol://domain
portion of the URL would get overwritten by the one in VendUrl. If you're code
relies on this buggy behaviour you need to fix it.


KNOWN ISSUES UPGRADING FROM 5.6.x

1. Perl 5.8.5 (unthreaded) or Perl 5.8.8 (threaded) or newer is now required.
Expand Down
2 changes: 1 addition & 1 deletion lib/Vend/Interpolate.pm
Expand Up @@ -2764,7 +2764,7 @@ sub tag_area {

$urlroutine = $opt->{secure} ? \&secure_vendUrl : \&vendUrl;

return $urlroutine->($page, $arg, undef, $opt);
return $urlroutine->($page, $arg, $r, $opt);
}

}
Expand Down

0 comments on commit a9db3e3

Please sign in to comment.